Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: duplicated feemarket params load #430

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Mar 19, 2024

The param loading is a significant source of memory allocations, reduce it as much as possible.

ref: #429

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@yihuang yihuang requested a review from mmsqe March 19, 2024 06:42
@yihuang yihuang enabled auto-merge (squash) March 19, 2024 08:21
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 63.15%. Comparing base (d97ce05) to head (78e5c7c).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #430      +/-   ##
===========================================
- Coverage    63.28%   63.15%   -0.14%     
===========================================
  Files          130      130              
  Lines        12348    12375      +27     
===========================================
+ Hits          7815     7816       +1     
- Misses        4017     4042      +25     
- Partials       516      517       +1     
Files Coverage Δ
app/ante/eip712.go 60.86% <100.00%> (+0.96%) ⬆️
app/ante/fee_checker.go 90.81% <100.00%> (-0.19%) ⬇️
app/ante/fee_market.go 73.91% <100.00%> (+1.18%) ⬆️
app/ante/fees.go 80.99% <100.00%> (-0.83%) ⬇️
app/ante/handler_options.go 79.72% <100.00%> (+1.78%) ⬆️
app/app.go 84.13% <100.00%> (ø)
x/evm/keeper/config.go 94.23% <100.00%> (+1.20%) ⬆️
x/evm/keeper/keeper.go 89.28% <ø> (+1.85%) ⬆️
x/evm/keeper/statedb.go 86.29% <100.00%> (-0.11%) ⬇️
x/feemarket/keeper/params.go 51.35% <ø> (-13.65%) ⬇️
... and 4 more

... and 1 file with indirect coverage changes

more cleanup

fix lint

fix test

fix test
@yihuang yihuang merged commit 71b7cd0 into crypto-org-chain:develop Mar 19, 2024
36 of 38 checks passed
@yihuang yihuang deleted the share-feemarket-params branch March 19, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants