Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: concurrent map read and write from priority nonce mempool #681

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Aug 21, 2024

Description

Closes: #675


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

go test -race -timeout 1800s -count 1 github.com/cosmos/cosmos-sdk/types/mempool
@mmsqe mmsqe force-pushed the release/v0.50.x_mempool_lock branch from 87e087b to 91b469c Compare August 22, 2024 02:10
@mmsqe mmsqe requested a review from yihuang August 22, 2024 02:11
@@ -287,6 +287,7 @@ func (mp *PriorityNonceMempool[C]) Insert(ctx context.Context, tx sdk.Tx) error

func (i *PriorityNonceIterator[C]) iteratePriority() Iterator {
// beginning of priority iteration
i.mempool.mtx.Lock()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream bug?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, but the fix seems tricky, instead of access priorityIndex/priorityNode directly, I'm thinking wrap sth like

type atomicPriorityIndex struct {
	atomic.RWMutex
	priorityIndex *ListIndex
	priorityNode *ListNode
}

func (i *atomicPriorityIndex) SetIndex(xxx) {
 	// lock
	i.priorityIndex.Set(xxx)
}

func (i *atomicPriorityIndex) NextNode() *ListNode {
	// lock
	return i.priorityNode.Next()
}

Comment on lines +113 to +115
for k, v := range i.priorityCounts {
counts[k] = v
}

Check warning

Code scanning / CodeQL

Iteration over map Warning

Iteration over map may be a possible source of non-determinism
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants