Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: signature verification result not cache between incarnations of same tx #565

Merged
merged 5 commits into from
Jul 15, 2024

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Jul 12, 2024

Closes: #564

Solution:

  • introduce incarnation cache that's shared between incarnations of the same tx

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

same tx

Closes: cosmos#564

Solution:
- introduce incarnation cache that's shared between incarnations of the
  same tx
@yihuang yihuang changed the title Problem: signature verification result not cache between incarnations of Problem: signature verification result not cache between incarnations of same tx Jul 12, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: yihuang <[email protected]>
types/context.go Outdated Show resolved Hide resolved
types/context.go Outdated Show resolved Hide resolved
x/auth/ante/sigverify.go Outdated Show resolved Hide resolved
@yihuang yihuang merged commit 5a1594f into crypto-org-chain:release/v0.50.x Jul 15, 2024
42 of 46 checks passed
@yihuang yihuang deleted the release/v0.50.x branch July 15, 2024 03:15
yihuang pushed a commit that referenced this pull request Jul 16, 2024
* Problem: gas consumed differs after enabled cache

* fix test

* Revert "Problem: gas consumed differs after enabled cache"

This reverts commit f33944e.

* Revert "Problem: signature verification result not cache between incarnations of same tx (#565)"

This reverts commit 5a1594f.

* keep interface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants