Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: panic when store not exists in historical version #435

Merged
merged 3 commits into from
May 17, 2024

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented May 16, 2024

Solution:

  • make a dummy store, so client get empty data instead of panic on nil pointer

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Solution:
- make a dummy store, so client get empty data instead of panic on nil pointer
@mmsqe
Copy link
Collaborator

mmsqe commented May 17, 2024

should we upstream to main, and might also need in sdk50?

@yihuang
Copy link
Collaborator Author

yihuang commented May 17, 2024

should we upstream to main, and might also need in sdk50?

yes, proposed to upstream and get approved.

@yihuang yihuang merged commit 5ba20d9 into crypto-org-chain:release/v0.47.x May 17, 2024
20 of 25 checks passed
@yihuang yihuang deleted the release/v0.47.x branch May 17, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants