Skip to content

Commit

Permalink
Update baseapp/abci.go
Browse files Browse the repository at this point in the history
Co-authored-by: yihuang <[email protected]>
Signed-off-by: mmsqe <[email protected]>
  • Loading branch information
mmsqe and yihuang authored Aug 17, 2023
1 parent 4808de4 commit addaf06
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion baseapp/abci.go
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ func (app *BaseApp) BeginBlock(req abci.RequestBeginBlock) (res abci.ResponseBeg
if err != nil {
panic(fmt.Errorf("preBeginBlock failed, height: %d, err: %w", req.Header.Height, err))

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods Warning

path flow from Begin/EndBlock to a panic call

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods Warning

Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt
}
// rsp.ConsensusParamsChanged is true from preBeginBlocker means ConsensusParams in database get changed
// rsp.ConsensusParamsChanged is true from preBeginBlocker means ConsensusParams in store get changed
// write non-nil app ConsensusParams to context
if rsp.ConsensusParamsChanged {
if cp := app.GetConsensusParams(ctx); cp != nil {

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods Warning

path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call
Expand Down

0 comments on commit addaf06

Please sign in to comment.