Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: sdk 0.50 is not used #1061

Merged
merged 42 commits into from
Jul 22, 2024
Merged

Problem: sdk 0.50 is not used #1061

merged 42 commits into from
Jul 22, 2024

Conversation

mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Jul 18, 2024

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Comment on lines +865 to +867
for acc := range maccPerms {
blockedAddrs[authtypes.NewModuleAddress(acc).String()] = !allowedReceivingModAcc[acc]
}

Check warning

Code scanning / CodeQL

Iteration over map Warning

Iteration over map may be a possible source of non-determinism
app/app.go Outdated
Comment on lines 948 to 955
for _, m := range app.mm.Modules {
if moduleWithName, ok := m.(module.HasName); ok {
moduleName := moduleWithName.Name()
if appModule, ok := moduleWithName.(appmodule.AppModule); ok {
modules[moduleName] = appModule
}
}
}

Check warning

Code scanning / CodeQL

Iteration over map Warning

Iteration over map may be a possible source of non-determinism
Copy link

socket-security bot commented Jul 19, 2024

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 72.52747% with 125 lines in your changes missing coverage. Please review.

Project coverage is 36.16%. Comparing base (7598bc4) to head (ea539c1).

Files Patch % Lines
app/export.go 9.37% 28 Missing and 1 partial ⚠️
app/versiondb.go 0.00% 15 Missing ⚠️
testutil/app.go 70.83% 10 Missing and 4 partials ⚠️
x/chainmain/client/cli/testnet.go 0.00% 13 Missing ⚠️
app/app.go 95.23% 6 Missing and 3 partials ⚠️
cmd/chain-maind/app/app.go 82.85% 4 Missing and 2 partials ⚠️
testutil/base_test_suite.go 90.16% 3 Missing and 3 partials ⚠️
app/genesis.go 0.00% 5 Missing ⚠️
x/nft/simulation/operations.go 0.00% 4 Missing ⚠️
app/upgrades.go 25.00% 2 Missing and 1 partial ⚠️
... and 12 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1061      +/-   ##
==========================================
+ Coverage   32.98%   36.16%   +3.18%     
==========================================
  Files         128      128              
  Lines       20009    16571    -3438     
==========================================
- Hits         6600     5993     -607     
+ Misses      12353     9480    -2873     
- Partials     1056     1098      +42     
Flag Coverage Δ
integration_tests 23.54% <67.05%> (+2.46%) ⬆️
integration_tests_byzantine 10.99% <66.47%> (+1.04%) ⬆️
integration_tests_gov 11.23% <66.76%> (+0.94%) ⬆️
integration_tests_grpc 11.22% <66.47%> (+0.92%) ⬆️
integration_tests_ibc 28.23% <67.05%> (+3.07%) ⬆️
integration_tests_ledger 11.21% <66.47%> (+1.02%) ⬆️
integration_tests_slow 11.21% <66.47%> (+1.02%) ⬆️
integration_tests_solomachine 11.03% <66.47%> (+1.05%) ⬆️
integration_tests_upgrade 11.22% <66.47%> (+0.92%) ⬆️
unit_tests 10.88% <62.52%> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +926 to +933
for _, m := range app.ModuleManager.Modules {
if moduleWithName, ok := m.(module.HasName); ok {
moduleName := moduleWithName.Name()
if appModule, ok := moduleWithName.(appmodule.AppModule); ok {
modules[moduleName] = appModule
}
}
}

Check warning

Code scanning / CodeQL

Iteration over map Warning

Iteration over map may be a possible source of non-determinism
@mmsqe mmsqe marked this pull request as ready for review July 22, 2024 01:32
@mmsqe mmsqe requested a review from a team as a code owner July 22, 2024 01:32
@mmsqe mmsqe enabled auto-merge July 22, 2024 09:21
@mmsqe mmsqe added this pull request to the merge queue Jul 22, 2024
Merged via the queue into crypto-org-chain:master with commit b325d1e Jul 22, 2024
33 of 35 checks passed
@yihuang
Copy link
Collaborator

yihuang commented Jul 23, 2024

/runsim

Copy link

Simulation tests started and triggered by /runsim.
Will update here when it succeeds or fails.
Can further check progress here

Copy link

/runsim simulation test has succeeded 🎉
Can further check here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants