Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded Hapi from v13 to v21 #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Upgraded Hapi from v13 to v21 #2

wants to merge 2 commits into from

Conversation

crsantos
Copy link
Owner

@crsantos crsantos commented Nov 24, 2022 •
edited
Loading

What

  • Bumped HapiJS from v13 to v21
  • Disabled file logging until I get a replacement for good-file
  • Added some basic tests
  • Added sample GitHub actions yml to start working on the test action

@crsantos crsantos self-assigned this Nov 24, 2022
@crsantos crsantos force-pushed the upgrade_hapijs branch 3 times, most recently from 1f531c0 to 32678c9 Compare November 25, 2022 12:09
@crsantos
Upgraded Hapi from v13 to v21
17b1599 
* Moved core server to lib/
* added tests
bmcustodio
bmcustodio approved these changes Nov 25, 2022
View reviewed changes
Copy link

@bmcustodio bmcustodio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have been ready since August, I've got more than twenty brands waiting. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmcustodio bmcustodio bmcustodio approved these changes

Assignees

@crsantos crsantos

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crsantos @bmcustodio