Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Whitelist change name key to not conflict with our official one #648

Merged

Conversation

LaurenceJJones
Copy link
Contributor

@LaurenceJJones LaurenceJJones commented Oct 25, 2024

Some users will just copy and paste, not to know they need to change the name key, so change this to be something other than the official one and add a comment on the latest docs to say "Must be unique" to try inform them to change it.

@LaurenceJJones LaurenceJJones merged commit 1f95eb8 into crowdsecurity:main Oct 25, 2024
1 of 2 checks passed
@LaurenceJJones LaurenceJJones deleted the whitelist_change_name_key branch October 25, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants