Problem: compile error on windows build (fix #338)

ignore polling exception version 0.0.17
cronos-labs · Aug 10, 2023 · ec11332 · ec11332
1 parent 3ec769d
commit ec11332
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,7 +1,12 @@
 # Changelog
 
 ## [Unreleased]
-use one binary for mac
+
+## [v0.0.17-alpha] - 2023-8-10
+- fix windows build
+
+## [v0.0.16-alpha] - 2023-8-8
+- use one binary for mac
 
 ## [v0.0.13-alpha] - 2023-6-15
 - Support apple arm64

diff --git a/CronosPlayUnreal.uplugin b/CronosPlayUnreal.uplugin
@@ -2,7 +2,7 @@
 	"FileVersion": 3,
 	"FriendlyName": "Cronos Play for Unreal Engine",
 	"Version": 1,
-	"VersionName": "v0.0.15-alpha",
+	"VersionName": "v0.0.17-alpha",
 	"EngineVersion": "5.2.0",
 	"Description": "Cronos labs",
 	"Category": "Programming",

diff --git a/Source/CronosPlayUnreal/Private/PlayCppSdkActor.cpp b/Source/CronosPlayUnreal/Private/PlayCppSdkActor.cpp
@@ -431,7 +431,8 @@ bool APlayCppSdkActor::BeginPolling(const FWalletconnectPollingDelegate &Out) {
                           });
 
             } // end of try
-            catch (const std::exception &e) {
+            catch (
+                const std::exception &) { // this is legimate exception, ignore
                 _pollingEvents = false;
                 AsyncTask(ENamedThreads::GameThread, [Out, userjsondata]() {
                     Out.ExecuteIfBound(userjsondata, TEXT("polling timeout"));

diff --git a/Source/ThirdParty/PlayCppSdkLibrary/PlayCppSdkLibrary.Build.cs b/Source/ThirdParty/PlayCppSdkLibrary/PlayCppSdkLibrary.Build.cs
@@ -40,8 +40,8 @@ public PlayCppSdkLibrary(ReadOnlyTargetRules Target) : base(Target) {
             PublicAdditionalLibraries.Add("ws2_32.lib");
 
         } else if (Target.Platform == UnrealTargetPlatform.Mac) {
-            PublicAdditionalLibraries.Add(Path.Combine(
-                    LibrariesPath, "Mac", "libplay_cpp_sdk.a"));
+            PublicAdditionalLibraries.Add(
+                Path.Combine(LibrariesPath, "Mac", "libplay_cpp_sdk.a"));
         } else if (Target.Platform == UnrealTargetPlatform.Linux) {
             PublicAdditionalLibraries.Add(
                 Path.Combine(LibrariesPath, "Linux", "libplay_cpp_sdk.a"));
@@ -53,8 +53,8 @@ public PlayCppSdkLibrary(ReadOnlyTargetRules Target) : base(Target) {
             PublicAdditionalLibraries.Add(Path.Combine(
                 LibrariesPath, "Android", "x86_64", "libplay_cpp_sdk.a"));
         } else if (Target.Platform == UnrealTargetPlatform.IOS) {
-            PublicAdditionalLibraries.Add(Path.Combine(
-                LibrariesPath, "iOS", "libplay_cpp_sdk.a"));
+            PublicAdditionalLibraries.Add(
+                Path.Combine(LibrariesPath, "iOS", "libplay_cpp_sdk.a"));
         }
     }
 }