Fix the "Change License" modal URL #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issues with link argument concatenation, which allows the plugin to use the old Partner Interface chooser interface: https://wiki.creativecommons.org/wiki/Partner_Interface Instead of the newer one located here: https://creativecommons.org/choose/ Commit also tidies up how the HTML markup is generated. See #52.
hugosolar
requested changes
Mar 27, 2019
| ); | ||
|
|
||
| // HTML markup. | ||
| $html = <<<CONTENT |
There was a problem hiding this comment.
Here we should stick to the wordpress quote standard
https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/
There was a problem hiding this comment.
Feel free to make the change yourself. We created our own plugin as I mention in #54.
|
We have removed the chooser integration from the plugin for the time being. We hope to add a prettier and better working version back in later: Integrate License Chooser · Issue #70. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes issues with how the "Change License" modal URL is generated, particularly with link argument concatenation.
This allows the plugin to use the old, "Partner Interface" chooser interface: https://wiki.creativecommons.org/wiki/Partner_Interface
Which this plugin relies on, instead of the newer one located here: https://creativecommons.org/choose/
This fixes #52, which I also reported.
Also:
CreativeCommons::select_license_html()method.Let me know if you have any questions.