-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Javascript/NPM fix #242
Javascript/NPM fix #242
Conversation
attribution" Explanation: Conciseness: The message is concise and to the point, conveying the core change. Clarity: It clearly states that the enhancement is related to adding image attribution to the template part. Specificity: While it doesn't explicitly mention displaying attribution below each image, it implies that the added attribution feature can be customized to suit different display preferences. Action-Oriented: The phrase "Add customizable image attribution" suggests a positive action taken to improve the template part.
scripts configuration - Updated start script to use relative path for nodemon - Replaced cgb-scripts to resolve NPM configuration errors - Ensured compatibility with the plugin development environment Closes: creativecommons#230
scripts configuration - Updated start script to use relative path for nodemon - Replaced cgb-scripts to resolve NPM configuration errors - Ensured compatibility with the plugin development environment Closes: creativecommons#230
Hi @RonaldRonnie, thanks for this contribution. Resolving this Issue would likely first require resolving the connected issue of: There is a lot of work here, and it would be helpful if your PR description more thoroughly documented all the changes you've made within this PR and whether or not it satisfies #211 or just #230 alone. I've also moved #230 to
🚧 status: blocked
|
Okay please, am happy to contribute
…On Fri, 18 Oct 2024 at 12:05 AM, possumbilities ***@***.***> wrote:
Hi @RonaldRonnie <https://github.com/RonaldRonnie>, thanks for this
contribution. Resolving this Issue would likely first require resolving the
connected issue of:
- #211
<#211>
There is a lot of work here, and it would be helpful if your PR
description more thoroughly documented all the changes you've made within
this PR and whether or not it satisfies #211
<#211>
or just #230
<#230>
alone.
I've also moved #230
<#230>
to 🚧 status: blocked
<https://github.com/creativecommons/wp-plugin-creativecommons/labels/%F0%9F%9A%A7%20status%3A%20blocked>
just because it seems we're approaching the territory where we likely need
to resolve #211
<#211>
rather than continue with any form of create-guten-block
—
Reply to this email directly, view it on GitHub
<#242 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BBVREPZ7YFWP27HSIMITWDTZ4ARCNAVCNFSM6AAAAABQD4D62OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRQGU3TEOJUGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
Hi again @RonaldRonnie Could you please fill out the Issue template, rather than deleting it, and include details related to my previous comment? |
So should open up another issue that will be fulfilled by my PR? because initially there were outdated modules and so i had to change to the one that supports the server to start and for that case one can start docker |
Hi @RonaldRonnie I'm closing this since it does not utilize the PR template, and seems out of scope with resolving the original now blocked Issued. Please feel free to open future PRs following the Contribution Guidelines |
scripts configuration
for nodemon
configuration errors
development environment