Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript/NPM fix #242

Closed
wants to merge 5 commits into from
Closed

Conversation

RonaldRonnie
Copy link

@RonaldRonnie RonaldRonnie commented Oct 17, 2024

scripts configuration

  • Updated start script to use relative path
    for nodemon
  • Replaced cgb-scripts to resolve NPM
    configuration errors
  • Ensured compatibility with the plugin
    development environment

attribution"

Explanation:

Conciseness: The message is concise and to the
point, conveying the core change.
Clarity: It clearly states that the enhancement
is related to adding image attribution to the
template part.
Specificity: While it doesn't explicitly mention
displaying attribution below each image,
 it implies that the added attribution feature
 can be customized to suit different display
 preferences.
Action-Oriented: The phrase "Add customizable
image attribution" suggests a positive action
taken to improve the template part.
scripts configuration

- Updated start script to use relative path
 for nodemon
- Replaced cgb-scripts to resolve NPM
configuration errors
- Ensured compatibility with the plugin
 development environment

Closes: creativecommons#230
scripts configuration

- Updated start script to use relative path
 for nodemon
- Replaced cgb-scripts to resolve NPM
 configuration errors
- Ensured compatibility with the plugin
 development environment

Closes: creativecommons#230
@RonaldRonnie RonaldRonnie requested review from a team as code owners October 17, 2024 14:24
@RonaldRonnie RonaldRonnie requested review from TimidRobot, possumbilities and ahmadbilaldev and removed request for a team October 17, 2024 14:24
@RonaldRonnie RonaldRonnie changed the title Ouma Javascript/NPM fix Oct 17, 2024
@RonaldRonnie
Copy link
Author

here when docker compose down and
docker compose up --build
are used , This help
Screenshot from 2024-10-17 17-30-30
containers to ensure everything is up-to-date. and thus the localhost:8080 can be accessed
image

@possumbilities
Copy link
Contributor

Hi @RonaldRonnie, thanks for this contribution. Resolving this Issue would likely first require resolving the connected issue of:

There is a lot of work here, and it would be helpful if your PR description more thoroughly documented all the changes you've made within this PR and whether or not it satisfies #211 or just #230 alone.

I've also moved #230 to 🚧 status: blocked Blocked & therefore, not ready for work just because it seems we're approaching the territory where we likely need to resolve #211 rather than continue with any form of create-guten-block

@RonaldRonnie
Copy link
Author

RonaldRonnie commented Oct 22, 2024 via email

@possumbilities
Copy link
Contributor

Hi again @RonaldRonnie Could you please fill out the Issue template, rather than deleting it, and include details related to my previous comment?

@RonaldRonnie
Copy link
Author

So should open up another issue that will be fulfilled by my PR? because initially there were outdated modules and so i had to change to the one that supports the server to start and for that case one can start docker

@possumbilities
Copy link
Contributor

Hi @RonaldRonnie I'm closing this since it does not utilize the PR template, and seems out of scope with resolving the original now blocked Issued.

Please feel free to open future PRs following the Contribution Guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug] Fix JavaScript/NPM (replace cgb-scripts)
2 participants