Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for accordions #126

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

OmarAmeen01
Copy link
Contributor

Fixes

This Pull Requests added the support for accordions without adding bulky code to the project

Technical details

  • added following classes and their respective styles for accordion in vocubulary.css
  1. .accordion-chevron-active,
  2. .accordion-header,
  3. .accordion-content,
  4. .hidden,
  5. .accordion-chevron
  • added JavaScript code to support accordion functionality
  • added updated documentation on how to use it

Tests

  • tested on chrome browser

Screenshots

accordian collapsed
accordian expanded

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Copy link

netlify bot commented Oct 7, 2024

Deploy Preview for vocabulary-docs ready!

Name Link
🔨 Latest commit b50b352
🔍 Latest deploy log https://app.netlify.com/sites/vocabulary-docs/deploys/670d45ad19890f0008c6dca6
😎 Deploy Preview https://deploy-preview-126--vocabulary-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@OmarAmeen01 OmarAmeen01 marked this pull request as ready for review October 7, 2024 18:08
@OmarAmeen01 OmarAmeen01 requested review from a team as code owners October 7, 2024 18:08
@OmarAmeen01 OmarAmeen01 requested review from TimidRobot, Shafiya-Heena, possumbilities, shailee-m and dhruvkb and removed request for a team October 7, 2024 18:08
@possumbilities
Copy link
Contributor

There's good work here, but for the time being see status of initial Issue.

After reviewing possible work directions here, it has become clear that more focused implementation specifications are needed for this to move stably forward. As such this Feature is now blocked by:

I'm leaving this PR open for now, and we'll revisit soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

[Feature] Add support for accordions
2 participants