Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the header title responsive in smaller screen devices #34

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Silvia-Wachira
Copy link

Fixes

Description

This PR makes the header more responsive. The hamburger menu does not cover the title on smaller screen sizes

Screenshots

screen-capture.5.webm

Checklist

  • [x My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Silvia-Wachira Silvia-Wachira requested a review from a team as a code owner October 10, 2024 16:30
@Silvia-Wachira Silvia-Wachira requested review from TimidRobot and possumbilities and removed request for a team October 10, 2024 16:30
@possumbilities
Copy link

@Silvia-Wachira There are a number of changes unrelated to the Issue this PR addressed, please revert/remove those changes.

@Silvia-Wachira
Copy link
Author

I will do that

@Silvia-Wachira
Copy link
Author

@possumbilities I am trying to revert the changes but the challenge I am facing is that I can't make the header responsive if docker is not set up in the local environment because then I won't see the web page. An issue had been raised about setting it up in the local environment and I worked on it (issue #29 and #30 )though it is yet to be reviewed. Interesting when I pulled the changes from the remote repository today I noticed that docker seems to have been set up though It's not working. So I need your guidance.

@possumbilities
Copy link

Hi @Silvia-Wachira There are a number of changes to this PR that are not related to the Issue can you please review and remove those changes?

@Silvia-Wachira
Copy link
Author

@possumbilities I am on it. I had done it but the same problem persists. Let me do some research

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

[Bug] Header is not responsive
2 participants