Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align header with Vocabulary current design system #222

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Dev-JoyA
Copy link
Contributor

@Dev-JoyA Dev-JoyA commented Oct 15, 2024

Fixes

Description

This PR is the continuation off #207 , It implement the vocabulary design system by:

  1. Adding the header tag in base.html to align with design system
  2. Properly linking the HTML page to vocabulary.css
  3. Properly connecting the HTML with vocabulary.js

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Dev-JoyA Dev-JoyA requested review from a team as code owners October 15, 2024 08:57
@Dev-JoyA Dev-JoyA requested review from TimidRobot, Shafiya-Heena and krysal and removed request for a team October 15, 2024 08:57
@Dev-JoyA Dev-JoyA changed the title Added implementention to aligh legal db web project with vocabulary d… Added implementention to aligh web projectwith vocabulary design system Oct 15, 2024
@TimidRobot TimidRobot self-assigned this Oct 15, 2024
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sync your fork and merge the main branch into this feature branch

@Dev-JoyA
Copy link
Contributor Author

Please sync your fork and merge the main branch into this feature branch

@TimidRobot Done, Thanks.

@TimidRobot TimidRobot changed the title Added implementention to aligh web projectwith vocabulary design system Added implementention to align web project with Vocabulary design system Oct 22, 2024
@TimidRobot TimidRobot changed the title Added implementention to align web project with Vocabulary design system Align header with Vocabulary current design system Oct 22, 2024
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes, as is, break the site:
Screenshot 2024-10-22 at 09-02-36 CC Legal Database

legal_db/templates/legal_db/base.html Outdated Show resolved Hide resolved
legal_db/templates/legal_db/base.html Outdated Show resolved Hide resolved
legal_db/templates/legal_db/base.html Outdated Show resolved Hide resolved
legal_db/templates/legal_db/base.html Show resolved Hide resolved
@Dev-JoyA
Copy link
Contributor Author

The changes, as is, break the site: Screenshot 2024-10-22 at 09-02-36 CC Legal Database

Screenshot 2024-10-22 at 18 16 43
Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

[Feature] Header isn't consistent with the current Vocabulary design system
2 participants