-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align footer with Vocabulary current design system #208
base: main
Are you sure you want to change the base?
Align footer with Vocabulary current design system #208
Conversation
…tem aligning correctly with footer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the code comments, please make sure this branch is synced with the main
branch of creativecommons/legaldb
@TimidRobot Done, Thank you |
…tem aligning correctly with footer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please sync your fork and merge the main branch into this feature branch.
This pull request (PR) shouldn't include Vocabulary changes.
@TimidRobot I removed the file with this command |
@TimidRobot, I have synced and merged the main branch into my branch. Currently, base.html does not have any connections to Vocabulary, as it stands in the main branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the Vocabulary files from the PR (not from the project).
Put another way: the PR shouldn't modify any Vocabulary files.
@TimidRobot resolved, Thank you |
Fixes
Description
This PR fixes the discrepancies between the website's footer and the design system, Including the inconsistency with the icons
Changes Made:
Aligned the footer elements with the current Vocabulary design system.
Screenshots
Before
Now
Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin