Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Header isn't consistent with the current Vocabulary design system #195

Open
1 task
Netacci opened this issue Oct 3, 2024 · 5 comments · Fixed by #207 · May be fixed by #222 or #235
Open
1 task

[Feature] Header isn't consistent with the current Vocabulary design system #195

Netacci opened this issue Oct 3, 2024 · 5 comments · Fixed by #207 · May be fixed by #222 or #235
Labels
💻 aspect: code Concerns the software code in the repository 🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing feature help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work

Comments

@Netacci
Copy link

Netacci commented Oct 3, 2024

Problem

The header design implemented does not match the current Vocabulary design system. It is also missing the Explore CC drop down.

Legaldb website

legal-head

Vocabulary design system

b-h

Description

There is a noticeable difference in the header layout and styling between what is defined in the design system and what is implemented on the legaldb website.

The header in the legaldb website should be center aligned to match what we have in the design system. We should also include the Explore CC dropdown and navigation section.

Additional context

  • Having consistent design patterns will improve both development efficiency and overall UX.
  • creativecommons/vocabulary: A cohesive system of design for Creative Commons

Implementation

  • I would be interested in implementing this feature.
@Netacci Netacci added ✨ goal: improvement Improvement to an existing feature 💻 aspect: code Concerns the software code in the repository 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🟩 priority: low Low priority and doesn't need to be rushed labels Oct 3, 2024
@TimidRobot TimidRobot added help wanted Open to participation from the community 🏁 status: ready for work Ready for work 🕹 aspect: interface Concerns end-users' experience with the software and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Oct 3, 2024
@Poison-Iveey
Copy link

Hi, @Netacci and @TimidRobot , I am working on this

@Queen-codes
Copy link
Contributor

hi @TimidRobot and @possumbilities I hope you are both having a great weekend.

I have started working on this issue and would like your input and suggestions before I proceed further than I already have. Currently, I have two approaches to fixing this issue.

The first option is to lift the CSS styles directly from Vocabulary and add them to the legal db CSS file, which could allow for quicker implementation and fixing of this issue.

The other option is to install the current version of Vocabulary in the codebase to maintain a consistent design system and make future updates easier. This might also be a solution to issue #196. If vocabulary is included, both issues can be fixed quickly.

I'd appreciate any insight on which approach is better. I look forward to hearing from you when office hours are open. Enjoy the rest of your weekend.

@TimidRobot TimidRobot changed the title [Feature] Header is not consistent with design system. [Feature] Header isn't consistent with the current Vocabulary design system Oct 7, 2024
@egbadon-victor
Copy link
Contributor

egbadon-victor commented Oct 16, 2024

HI @TimidRobot

While trying to resolve this issue, a major question came to mind. This repo utilizes webpack to compile the sass files into css. While the new vocabulary implementation does not require sass, I can't ignore the minification that occurs too. So here is the question.

In the implementation of the new vocabulary design system in the legaldb repo, could we use webpack to minify the vocabulary source files into a single css and js file, then link that in the django templates, or is webpack going to be removed from this project upon implementation of the new vocabulary design system?

I believe the minification would be a welcome step as it effectively reduces style and script sizes, which also reduces payload size. But this all depends on the direction of the project going forward. Your input would be of great assistance here

@TimidRobot
Copy link
Member

@egbadon-victor I expect webpack will eventually be removed. Our CDN handles minification.

@egbadon-victor
Copy link
Contributor

@TimidRobot this is understood. Thank you for the feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing feature help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work
Projects
Status: Backlog
Status: Backlog
5 participants