Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] Corrected accessibility issues found on website #822

Conversation

Dev-JoyA
Copy link
Contributor

@Dev-JoyA Dev-JoyA commented Oct 6, 2024

Fixes

Description

This PR addresses the following accessibility issues:

  1. Ensured that all links contain meaningful text where necessary and added aria-labels for improved screen reader accessibility.
  2. Cross-checked all image tags to confirm the presence of descriptive alt text, and updated or added alt text where appropriate for better understanding.
  3. Verified that all forms adhere to the requirements outlined in the design system, improving accessibility and usability.
  4. Added the document language attribute () to improve how screen readers interpret the content.

Technical details

A comprehensive accessibility audit of all files in the templates was conducted, to systematically identify and resolve issues. Addressing these concerns will improve the user experience, particularly for visitors with disabilities.

The PR was cloned and pulled to my local machine, where I carefully reviewed and resolved the identified problems.

Regarding the forms, no labels were added, as per the design system's requirements, which specify that the forms do not require labels.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Dev-JoyA Dev-JoyA requested review from a team as code owners October 6, 2024 12:04
@Dev-JoyA Dev-JoyA requested review from TimidRobot, possumbilities and akmadian and removed request for a team October 6, 2024 12:04
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! Please see code comments

themes/vocabulary_theme/templates/layout.html Outdated Show resolved Hide resolved
@Dev-JoyA
Copy link
Contributor Author

Dev-JoyA commented Oct 8, 2024

@TimidRobot I have made all necessary changes. Kindly review.

Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work!

@TimidRobot TimidRobot merged commit b72d68e into creativecommons:main Oct 8, 2024
1 check passed
@TimidRobot TimidRobot self-assigned this Oct 8, 2024
@Dev-JoyA
Copy link
Contributor Author

Dev-JoyA commented Oct 8, 2024

@TimidRobot I really don’t think it’s partially fixed , I think it’s completely fixed because the other bullet point was to add label for forms
And the only forms i found was in the footer , which I cross checked with the requirement in the Design System.
And the Design system does not have labels added to the form .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Accessibility] Accessibility Issues Identified on the Website
2 participants