Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update node packages #714

Closed
wants to merge 1 commit into from
Closed

update node packages #714

wants to merge 1 commit into from

Conversation

possumbilities
Copy link
Contributor

Description

  • update node modules

Technical details

  • extract-loader : ^5.1.0 >> ^4.0.3
  • postcss-loader: ^5.1.0 >> ^7.2.4

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@possumbilities possumbilities self-assigned this Apr 24, 2023
@possumbilities possumbilities requested review from a team as code owners April 24, 2023 21:11
@possumbilities possumbilities requested review from Cronus1007 and removed request for a team April 24, 2023 21:11
@possumbilities possumbilities changed the title updating node packages update node packages Apr 24, 2023
@possumbilities
Copy link
Contributor Author

Holding on this, after making the PR I realized I didn't manually rebuild the project (had assumed it would live rebuild). A SASS build error occurs on rebuild.

./sass/main.scss 39 bytes [built] [code generated] [1 error]

ERROR in ./sass/main.scss
Module build failed (from ./node_modules/extract-loader/lib/extractLoader.js):
/workspaces/creativecommons.github.io-source/webpack/sass/main.scss:2
import ___CSS_LOADER_API_IMPORT___ from "../node_modules/css-loader/dist/runtime/api.js";
^^^^^^

SyntaxError: Cannot use import statement outside a module
    at new Script (node:vm:100:7)
    at /workspaces/creativecommons.github.io-source/webpack/node_modules/extract-loader/lib/extractLoader.js:98:28
    at Generator.next (<anonymous>)
    at step (/workspaces/creativecommons.github.io-source/webpack/node_modules/babel-runtime/helpers/asyncToGenerator.js:17:30)
    at /workspaces/creativecommons.github.io-source/webpack/node_modules/babel-runtime/helpers/asyncToGenerator.js:35:14
    at new Promise (<anonymous>)
    at new F (/workspaces/creativecommons.github.io-source/webpack/node_modules/core-js/library/modules/_export.js:36:28)
    at /workspaces/creativecommons.github.io-source/webpack/node_modules/babel-runtime/helpers/asyncToGenerator.js:14:12
    at evalModule (/workspaces/creativecommons.github.io-source/webpack/node_modules/extract-loader/lib/extractLoader.js:165:63)
    at evalDependencyGraph (/workspaces/creativecommons.github.io-source/webpack/node_modules/extract-loader/lib/extractLoader.js:167:12)

webpack 5.80.0 compiled with 1 error in 10219 ms

I'll need to look into this further to verify how to correct this. I have a suspicion that some of these updates are tied to Vocabulary and by proxy Vue and if so these updates may have to hold until Vocabulary is addressed.

Closing for the time being until I can resolve the above.

@possumbilities possumbilities removed request for a team and Cronus1007 April 24, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant