displayed a message when no resources are found matching the filters #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nandu-99
requested review from
Shafiya-Heena and
possumbilities
and removed request for
a team
Murdock9803
reviewed
Jul 11, 2024
| @@ -50,6 +50,9 @@ <h1>Resources</h1> | |||
|
|
|||
| <!-- This is the section that shows all the resource cards in the site. | |||
There was a problem hiding this comment.
This documentation should be shifted to just before the #thumbnaillist, and a different descriptive comment should be added here related to the noThumbnailsMessage
added 2 commits
July 14, 2024 16:30
| @@ -47,6 +47,20 @@ h1 { | |||
| list-style: none; | |||
| } | |||
|
|
|||
| .hidden { | |||
| display: none !important; | |||
There was a problem hiding this comment.
we want to avoid the use of !important in our cascade.
| display: none !important; | ||
| } | ||
|
|
||
| .visible{ |
There was a problem hiding this comment.
we don't need a class of visible, and should operate off of things being visible until made invisible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Description
Added a feature to display a message when no resources match the selected combination of filters in the topic, medium, and language categories. This enhancement ensures that users are informed when their filter criteria do not yield any results, preventing confusion and providing clarity on the absence of matching resources.
Screenshots
Checklist
Update index.md).mainormaster).visible errors.