Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure focal point tool can be used without dragging motion #15904

Open
wants to merge 14 commits into
base: 5.5
Choose a base branch
from
Open

Ensure focal point tool can be used without dragging motion #15904

wants to merge 14 commits into from

Commits on Sep 24, 2024

  1. Get click-to-move focal point working for non-crop-enabled scenario

    Lupe Camacho authored and Lupe Camacho committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    5f0c497 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Add new function for checking if focal point coords are inside image … 

    …viewport
    Lupe Camacho authored and Lupe Camacho committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    3cd429d View commit details
    Browse the repository at this point in the history

  2. Rewrite code pulled from focal drag for focal click

    Lupe Camacho authored and Lupe Camacho committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    b1e293d View commit details
    Browse the repository at this point in the history

  3. Merge 5.5 and build

    Lupe Camacho authored and Lupe Camacho committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    e387d91 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Trigger handleClickToMove for focal point placement only when the foc… 

    …al point is not being dragged
    Lupe Camacho authored and Lupe Camacho committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    64e4c57 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Merge and build 5.5

    Lupe Camacho authored and Lupe Camacho committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    25167d3 View commit details
    Browse the repository at this point in the history

  2. Finish clickToMove function for focal point

    Lupe Camacho authored and Lupe Camacho committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    312efec View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Undo changes in Preview modal

    Lupe Camacho authored and Lupe Camacho committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    057680d View commit details
    Browse the repository at this point in the history

  2. Add conditional to ensure cropper is not being dragged to prevent foc… 

    …al point moving as a result of dragging
    Lupe Camacho authored and Lupe Camacho committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    1c699ff View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Add comments and docs

    Lupe Camacho authored and Lupe Camacho committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    ebb8b38 View commit details
    Browse the repository at this point in the history

  2. Click to pick up focal point; TODO fix cropper and handle dragging wh… 

    …en focal point is picked up
    Lupe Camacho authored and Lupe Camacho committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    7127a75 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Change cursor when focal point is picked up\

    Lupe Camacho authored and Lupe Camacho committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    be5e07a View commit details
    Browse the repository at this point in the history

  2. Prevent scaling from competing with focal point

    Lupe Camacho authored and Lupe Camacho committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    5284daf View commit details
    Browse the repository at this point in the history

  3. Finish up

    Lupe Camacho authored and Lupe Camacho committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    162a095 View commit details
    Browse the repository at this point in the history