vue admintable - sortable header styles (v4) #15901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Style sortable headers in the vue admintable so they look the same as in element index tables.
I changed the hover style (background & font colour) and the ordered header style (added icons and adjusted colours).
At the moment, we don’t use sorting in this type of table in v4, so the screenshots are from v5, but I think those styles should be added to v4, too (for consistency and just in case).
Separate PR coming for v5 as there are some differences in how the styles are handled.
Before:
After:
Related issues
#15897