Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for mocking functions with rvalue arguments. #37

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Add support for mocking functions with rvalue arguments. #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions include/GUnit/GMock.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ class GMock {
? msgs.back().c_str()
: TName::c_str());
}
return ptr->Invoke(args...);
return ptr->Invoke(std::forward<TArgs>(args)...);
}

template <class TName, class R, class... TArgs>
Expand Down Expand Up @@ -253,10 +253,10 @@ class GMock {
auto *f =
static_cast<FunctionMocker<R(TArgs...)> *>(fs[TName::c_str()].get());
f->SetOwnerAndName(this, TName::c_str());
return f->Invoke(args...);
return f->Invoke(std::forward<TArgs>(args)...);
}

return not_expected<TName, R, TArgs...>(args...);
return not_expected<TName, R, TArgs...>(std::forward<TArgs>(args)...);
}

template <class TName, class R, class B, class... TArgs>
Expand Down
18 changes: 18 additions & 0 deletions test/GMock.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1093,3 +1093,21 @@ TEST(GMock, ShouldMockTemplates) {

sut.bar();
}

struct interface_rvalue {
virtual ~interface_rvalue() = default;
virtual void f(int&&) = 0;
};


TEST(GMock, ShouldMockRvalues) {
using namespace testing;
StrictGMock<interface_rvalue> mock{};

EXPECT_CALL(mock, (f)(_)).WillOnce([](int&& value){
EXPECT_EQ(6, value);
});

mock.object().f(6);
}