Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] use sub commands for python CLI #1292

Merged
merged 26 commits into from
Jul 24, 2024

Conversation

Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Jul 23, 2024

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 2.73973% with 284 lines in your changes missing coverage. Please review.

Project coverage is 76.28%. Comparing base (f53979a) to head (63c4cea).
Report is 112 commits behind head on main.

Files Patch % Lines
src/bidspm/bidspm.py 0.00% 117 Missing ⚠️
src/bidspm/parsers.py 0.00% 104 Missing ⚠️
src/bidspm/cli.py 0.00% 63 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1292      +/-   ##
==========================================
- Coverage   79.57%   76.28%   -3.30%     
==========================================
  Files         285      291       +6     
  Lines        7742     8074     +332     
  Branches       40       64      +24     
==========================================
- Hits         6161     6159       -2     
- Misses       1565     1915     +350     
+ Partials       16        0      -16     
Flag Coverage Δ
cli 0.00% <0.00%> (-39.00%) ⬇️
macos-13_matlab-R2023b_fast 60.51% <50.00%> (?)
macos-13_matlab-R2023b_slow 58.38% <87.50%> (?)
macos-latest_matlab-R2023a_fast ?
macos-latest_matlab-R2023a_slow ?
octave 76.47% <100.00%> (+0.76%) ⬆️
ubuntu-latest_matlab-R2023a_fast ?
ubuntu-latest_matlab-R2023a_slow ?
ubuntu-latest_matlab-R2023b_fast 60.51% <50.00%> (?)
ubuntu-latest_matlab-R2023b_slow 58.37% <87.50%> (?)
windows-latest_matlab-R2023b_slow 58.38% <87.50%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Remi-Gau Remi-Gau changed the title Enh/sub commands [ENH] use sub commands for python CLI Jul 23, 2024
@Remi-Gau Remi-Gau marked this pull request as ready for review July 24, 2024 06:41
Copy link
Contributor

sourcery-ai bot commented Jul 24, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@Remi-Gau Remi-Gau merged commit f4b986f into cpp-lln-lab:main Jul 24, 2024
25 of 28 checks passed
@Remi-Gau Remi-Gau deleted the enh/sub_commands branch July 24, 2024 12:46
Remi-Gau added a commit to Remi-Gau/bidspm that referenced this pull request Jul 24, 2024
* start adding sub commands

* preproc subcommand

* deal with create roi parser

* deal with default_model sub command

* deal with bms action

* deal with stats actions

* start adapting cli

* add test for command building

* add test for CLI for preproc, smooth...

* add test for command building for stats

* add test for command building for bms

* rename function

* start switching CLI

* several fixes

* more fix

* keep switchingµ

* fix

* fix

* linti

* fixes

* fixes

* minor fixes

* additional fixes

* fix output ROI

* visualize output in circle ci
Remi-Gau added a commit that referenced this pull request Jul 30, 2024
* start adding a 3 group dataset

* [ENH] use sub commands for python CLI (#1292)

* start adding sub commands

* preproc subcommand

* deal with create roi parser

* deal with default_model sub command

* deal with bms action

* deal with stats actions

* start adapting cli

* add test for command building

* add test for CLI for preproc, smooth...

* add test for command building for stats

* add test for command building for bms

* rename function

* start switching CLI

* several fixes

* more fix

* keep switchingµ

* fix

* fix

* linti

* fixes

* fixes

* minor fixes

* additional fixes

* fix output ROI

* visualize output in circle ci

* add temp script for boutiques and bids model graph

* start adding tweaks

* try 3 groups

* rename file

* update code and tests

* add multi group demo

* fixes

* adapt example

* fix contrasts

* deal with results

* update doc

* minor changes

* tmp

* refactor

* refactor

* refactor

* several fixes

* several fixes

* fix and refactor

* fix and refactor

* fix and refactor

* fix models

* fix

* fix

* fix fast tests

* fixes

* fix and implement F test

* run group level node by node

* add F test to demo

* octave fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use sub commands for python CLI
1 participant