Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] try not indexing dependencies for a speed up #1129

Merged
merged 8 commits into from
Aug 19, 2023

Conversation

Remi-Gau
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #1129 (0410995) into main (03c1bae) will increase coverage by 0.06%.
Report is 1 commits behind head on main.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##             main    #1129      +/-   ##
==========================================
+ Coverage   79.01%   79.07%   +0.06%     
==========================================
  Files         279      279              
  Lines        7534     7538       +4     
  Branches       40       40              
==========================================
+ Hits         5953     5961       +8     
+ Misses       1565     1561       -4     
  Partials       16       16              
Flag Coverage Δ
cli 38.99% <ø> (ø)
macos-latest_matlab-R2022b ?
macos-latest_matlab-R2022b_fast 66.50% <80.00%> (?)
macos-latest_matlab-R2022b_slow 52.24% <50.00%> (?)
octave 75.34% <90.00%> (?)
ubuntu-latest_matlab-R2022b ?
ubuntu-latest_matlab-R2022b_fast 66.65% <80.00%> (?)
ubuntu-latest_matlab-R2022b_slow 52.23% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/bids/initBids.m 100.00% <ø> (ø)
src/IO/getData.m 95.23% <80.00%> (+0.50%) ⬆️
src/bids_model/addConfoundsToDesignMatrix.m 95.83% <100.00%> (ø)
src/workflows/stats/bidsResults.m 56.56% <100.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Remi-Gau Remi-Gau marked this pull request as ready for review August 19, 2023 02:39
@Remi-Gau Remi-Gau merged commit 4f94935 into cpp-lln-lab:main Aug 19, 2023
24 of 27 checks passed
@Remi-Gau Remi-Gau deleted the perf branch August 21, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant