fix: Append encoding='utf-8' to open #1423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bear0330
changed the title
|
Could you please fix the formatting issues? You can run |
|
Done :) |
ajanitshimanga
pushed a commit
to ajanitshimanga/MemGPT
that referenced
this pull request
Jun 5, 2024
mattzh72
pushed a commit
that referenced
this pull request
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the purpose of this pull request.
this is a pull request to fix #1270
How to test
Just simply append encoding='utf-8' for all non-binary open
Have you tested this PR?
Yes, tested in my non-English windows machine.
Related issues or PRs
#1270
Is your PR over 500 lines of code?
No