Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the myself contact at instance creation #4474

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Fix the myself contact at instance creation #4474

merged 1 commit into from
Oct 15, 2024

Conversation

nono
Copy link
Member

@nono nono commented Oct 10, 2024

  • add the displayName
  • add the index.byFamilyNameGivenNameEmailCozyUrl

In theory, there is a service from the contacts webapp that adds them, launched via an @vevent trigger on the io.cozy.contacts. But, the stack creates the myself contact before installing the contacts webapp at instance creation. Thus, the service is not launched. The easy fix is to just add the missing field when creating the myself contact.

@nono nono requested a review from zatteo October 10, 2024 15:25
@nono nono requested a review from a team as a code owner October 10, 2024 15:25
model/contact/contacts.go Outdated Show resolved Hide resolved
- add the displayName
- add the index.byFamilyNameGivenNameEmailCozyUrl

In theory, there is a service from the contacts webapp that adds them,
launched via an `@vevent` trigger on the io.cozy.contacts. But, the
stack creates the myself contact before installing the contacts webapp
at instance creation. Thus, the service is not launched. The easy fix is
to just add the missing field when creating the myself contact.
Copy link
Contributor

@zatteo zatteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nono nono merged commit 092abce into master Oct 15, 2024
4 checks passed
@nono nono deleted the fix-myself branch October 15, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants