Add external indexers for RAG #4457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paultranvan
approved these changes
Sep 3, 2024
worker/index/index.go
Outdated
| } | ||
| if !needIndexation { | ||
| // TODO we should patch the metadata in the vector db when a | ||
| // file has been moved/renamed. |
There was a problem hiding this comment.
There are also additional metadata that might be eventually be useful, e.g. the metadata.referenceDate, the metadata.qualification.label, ... At some point we will need to list which metadata to index
There was a problem hiding this comment.
Aren't we only sending the file's content? In which case metadata or path changes seem irrelevant.
nono
force-pushed
the
external-indexers
branch
from
1f07d82
to
c89116d
Compare
taratatach
reviewed
Sep 11, 2024
worker/index/index.go
Outdated
| } | ||
| if !needIndexation { | ||
| // TODO we should patch the metadata in the vector db when a | ||
| // file has been moved/renamed. |
There was a problem hiding this comment.
Aren't we only sending the file's content? In which case metadata or path changes seem irrelevant.
nono
force-pushed
the
external-indexers
branch
from
c89116d
to
8660cc6
Compare
paultranvan
reviewed
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.