Add a linter to disable fmt.Printf in code #4154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Printf is often used while developping to inspect or debug code. It happens that these statements are forgotten and commited. We can prevent that by using a linter to disable them. We have some cases where fmt.Printf was used to print useful stuff, like in the CLI. They have been rewritten in fmt.Fprintf to avoid been flagged by the linter.
taratatach
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Printf is often used while developping to inspect or debug code. It happens that these statements are forgotten and commited. We can prevent that by using a linter to disable them.
We have some cases where fmt.Printf was used to print useful stuff, like in the CLI. They have been rewritten in fmt.Fprintf to avoid been flagged by the linter.