Make the initial synchronization of a sharing faster #4147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user accepts to synchronize a sharing to their Cozy, the stack starts a replication of the io.cozy.files, and uploads the files inside the sharing. We can make this process faster by batching calls to the changes feed. It is particulary useful when there are lots of documents in the io.cozy.shared database, from other sharings.
nono
force-pushed
the
faster-sharing-init
branch
from
b8ddd30
to
22eb86f
Compare
taratatach
reviewed
Oct 10, 2023
Comment on lines
+59
to
+60
| m := members[i] | ||
| g.Go(func() error { |
There was a problem hiding this comment.
Don't we need to pass m as an argument to the goroutine to create a closure?
There was a problem hiding this comment.
errgroup doesn't allow to pass arguments to the goroutine. That's why I have written for i := range members { m := members[i] instead of the shorter for _, m := range members. It forces m to have the correct range.
In the future, I hope that https://github.com/golang/go/wiki/LoopvarExperiment will make things easier.
taratatach
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.