fix: Flagship's OAuth clients modal links opening #4140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the OAuth clients limit is exceeded, we redirect every HTML request for an app to the dedicated modal page with links to subscribe to a different offer or manage connected OAuth clients. Although we want these links to open in the same tab on the Web, we want them to open in a new tab when viewed from the flagship app.
Ldoppea
approved these changes
Sep 27, 2023
taratatach
deleted the
fix/open-clients-limit-exceeded-links-in-new-tab-from-flagship-app
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the OAuth clients limit is exceeded, we redirect every HTML
request for an app to the dedicated modal page with links to subscribe
to a different offer or manage connected OAuth clients.
Although we want these links to open in the same tab on the Web, we
want them to open in a new tab when viewed from the flagship app.