Allow to patch the message of a trigger

docs/jobs.md

@@ -795,7 +795,7 @@ Accept: application/vnd.api+json
 ### PATCH /jobs/triggers/:trigger-id
 
 This route can be used to change the frequency of execution of a `@cron`
-trigger.
+trigger, or the message of any trigger.
 
 #### Request
 

model/job/mem_scheduler.go

@@ -145,6 +145,15 @@ func (s *memScheduler) GetTrigger(db prefixer.Prefixer, id string) (Trigger, err
 	return t, nil
 }
 
+// UpdateMessage changes the message for the given trigger.
+func (s *memScheduler) UpdateMessage(db prefixer.Prefixer, trigger Trigger, message json.RawMessage) error {
+	s.mu.RLock()
+	defer s.mu.RUnlock()
+	infos := trigger.Infos()
+	infos.Message = Message(message)
+	return couchdb.UpdateDoc(db, infos)
+}
+
 // UpdateCron will change the frequency of execution for the given trigger.
 func (s *memScheduler) UpdateCron(db prefixer.Prefixer, trigger Trigger, arguments string) error {
 	s.mu.RLock()

model/job/redis_scheduler.go

@@ -425,6 +425,13 @@ func (s *redisScheduler) GetTrigger(db prefixer.Prefixer, id string) (Trigger, e
 	return t, nil
 }
 
+// UpdateMessage changes the message for the given trigger.
+func (s *redisScheduler) UpdateMessage(db prefixer.Prefixer, trigger Trigger, message json.RawMessage) error {
+	infos := trigger.Infos()
+	infos.Message = Message(message)
+	return couchdb.UpdateDoc(db, infos)
+}
+
 // UpdateCron will change the frequency of execution for the given trigger.
 func (s *redisScheduler) UpdateCron(db prefixer.Prefixer, trigger Trigger, arguments string) error {
 	if trigger.Type() != "@cron" {

model/job/scheduler.go

@@ -2,6 +2,7 @@ package job
 
 import (
 	"context"
+	"encoding/json"
 	"time"
 
 	"github.com/cozy/cozy-stack/model/permission"
@@ -48,6 +49,7 @@ type (
 		PollScheduler(now int64) error
 		AddTrigger(trigger Trigger) error
 		GetTrigger(db prefixer.Prefixer, id string) (Trigger, error)
+		UpdateMessage(db prefixer.Prefixer, trigger Trigger, message json.RawMessage) error
 		UpdateCron(db prefixer.Prefixer, trigger Trigger, arguments string) error
 		DeleteTrigger(db prefixer.Prefixer, id string) error
 		GetAllTriggers(db prefixer.Prefixer) ([]Trigger, error)

web/jobs/jobs.go

@@ -413,13 +413,22 @@ func patchTrigger(c echo.Context) error {
 	if _, err := jsonapi.Bind(c.Request().Body, &req); err != nil {
 		return wrapJobsError(err)
 	}
-	if req.Arguments == "" {
-		return jsonapi.BadRequest(errors.New("Only arguments can be patched"))
+	if req.Arguments == "" && len(req.Message) == 0 {
+		return jsonapi.BadRequest(errors.New("Only arguments and message can be patched"))
 	}
 
-	if err := sched.UpdateCron(inst, t, req.Arguments); err != nil {
-		return wrapJobsError(err)
+	if len(req.Message) > 0 {
+		if err := sched.UpdateMessage(inst, t, req.Message); err != nil {
+			return wrapJobsError(err)
+		}
+	}
+
+	if req.Arguments != "" {
+		if err := sched.UpdateCron(inst, t, req.Arguments); err != nil {
+			return wrapJobsError(err)
+		}
 	}
+
 	return jsonapi.Data(c, http.StatusOK, apiTrigger{infos, inst}, nil)
 }
 

web/jobs/jobs_test.go

@@ -359,7 +359,7 @@ func TestJobs(t *testing.T) {
 			attrs.ValueEqual("worker", "print")
 		})
 
-		t.Run("PatchSuccess", func(t *testing.T) {
+		t.Run("PatchArgumentsSuccess", func(t *testing.T) {
 			e := testutils.CreateTestClient(t, ts.URL)
 
 			e.PATCH("/jobs/triggers/"+triggerID).
@@ -375,6 +375,24 @@ func TestJobs(t *testing.T) {
 				Expect().Status(200)
 		})
 
+		t.Run("PatchMessageSuccess", func(t *testing.T) {
+			e := testutils.CreateTestClient(t, ts.URL)
+
+			e.PATCH("/jobs/triggers/"+triggerID).
+				WithHeader("Authorization", "Bearer "+token).
+				WithHeader("Content-Type", "application/json").
+				WithBytes([]byte(`{
+        "data": {
+          "attributes": { 
+			"message": {
+			  "folder_to_save": "123"
+			}
+          }
+        }
+      }`)).
+				Expect().Status(200)
+		})
+
 		t.Run("GetSuccess", func(t *testing.T) {
 			e := testutils.CreateTestClient(t, ts.URL)