feat: Add Flagship certification for MaBulle #4130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taratatach
approved these changes
Sep 20, 2023
| checkNoErr(viper.BindPFlag("flagship.apk_package_names", flags.Lookup("flagship-apk-package-names"))) | ||
|
|
||
| flags.StringSlice("flagship-apk-certificate-digests", []string{"u2eUUnfB4Y7k7eqQL7u2jiYDJeVBwZoSV3PZSs8pttc="}, "SHA-256 hash (base64 encoded) of the flagship app's signing certificate on android") | ||
| flags.StringSlice("flagship-apk-certificate-digests", []string{"u2eUUnfB4Y7k7eqQL7u2jiYDJeVBwZoSV3PZSs8pttc=", "xay9CTu3gSxR+0eG690lpahEx+5Hpg37mgTgFq2PL38="}, "SHA-256 hash (base64 encoded) of the flagship app's signing certificate on android") |
There was a problem hiding this comment.
Out of curiosity, why do we have only 2 values here when we have 3 for the other 2 flags?
There was a problem hiding this comment.
I'm not sure why other io.cozy.drive.mobile is declared here. For now Flagship certification is fully functional only for io.cozy.flagship.mobile and io.cozy.flagship.mobile.mabulle
nono
reviewed
Sep 20, 2023
I forgot that we can easily override this part on our servers. So yes I agree with your suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will publish a new Android & iOS app named Ma Bulle. This PR provides info to enable Flagship certification for this new app.