Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

used more precise login endpoints #574

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

EugeneLoy
Copy link
Contributor

@balta2ar Thank you for merging #569
Based on troubleshooting from #559 there is small tweak to login endpoints that should be made in order to fix the problem for all users. This PR addresses this.

@balta2ar
Copy link
Member

balta2ar commented Dec 9, 2019

Since you're on it, do you think you could also take a look at #573?

@EugeneLoy
Copy link
Contributor Author

@balta2ar Ok, I'll look into it later this week.

@EugeneLoy
Copy link
Contributor Author

@balta2ar Hi. I've amended this PR, so login will work on other openedx sites (ones that received no change to the login process).

This fixes #573 (fun-mooc.fr).

Note, however that this is somewhat nominal fix, as it seems that downloading video from fun-mooc.fr is broken in it's own way.

I've tried couple of courses and only resources were downloaded (not video). It looks to me that the problem is either because FUN does not host videos on youtube or something is broken with parsing FUN course pages.

Anyway, this is just a guess as I am not willing to tackle this issue.

EugeneLoy referenced this pull request Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants