Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AV-82517] Remove the configuration type from the cluster resource #207

Merged
merged 9 commits into from
Jul 19, 2024

Conversation

PaulomeeCb
Copy link
Contributor

@PaulomeeCb PaulomeeCb commented Jul 18, 2024

Jira

  • AV-82517

Description

Removing configuration type from acceptance tests and clusters folder as the field was removed as part of Day 1 changes.

Type of Change

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Manual Testing Approach

How was this change tested and do you have evidence? (REQUIRED: Select at least 1)

  • Manually tested
  • Unit tested
  • Acceptance tested
  • Unable to test / will not test (Please provide comments in section below)

Testing

Testing

Required Checklist:

  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if required)
  • I have run make fmt and formatted my code

Further comments

@PaulomeeCb PaulomeeCb requested review from a team as code owners July 18, 2024 19:32
@PaulomeeCb PaulomeeCb changed the title AV-82517 - Removing configuration type from acceptance tests as the field was re… AV-82517 - Fixing acceptance tests Jul 18, 2024
@PaulomeeCb PaulomeeCb merged commit 24b4f1c into main Jul 19, 2024
4 checks passed
@aniket-Kumar-c aniket-Kumar-c added the bug Something isn't working label Sep 11, 2024
@aniket-Kumar-c aniket-Kumar-c changed the title AV-82517 - Fixing acceptance tests [AV-82517] Fixing acceptance tests Sep 11, 2024
@aniket-Kumar-c aniket-Kumar-c changed the title [AV-82517] Fixing acceptance tests [AV-82517] Remove the configuration type from the cluster resource Sep 17, 2024
@aniket-Kumar-c aniket-Kumar-c added enhancement New feature or request and removed bug Something isn't working labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants