Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release documentation #186

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

aniket-Kumar-c
Copy link
Collaborator

@aniket-Kumar-c aniket-Kumar-c commented Apr 19, 2024

Jira

Description

Please include a summary of the fix/feature/change, including any relevant motivation and context.

Type of Change

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Manual Testing Approach

How was this change tested and do you have evidence? (REQUIRED: Select at least 1)

  • Manually tested
  • Unit tested
  • Acceptance tested
  • Unable to test / will not test (Please provide comments in section below)

Testing

Testing

Required Checklist:

  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if required)
  • I have run make fmt and formatted my code

Further comments

Copy link
Member

@Talina06 Talina06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Aniket for getting this PR up! added few suggestions

docs/guides/1.2.0-upgrade-guide.md Outdated Show resolved Hide resolved
docs/guides/1.2.0-upgrade-guide.md Outdated Show resolved Hide resolved
docs/guides/1.2.0-upgrade-guide.md Outdated Show resolved Hide resolved
docs/guides/1.2.0-upgrade-guide.md Show resolved Hide resolved
docs/guides/1.2.0-upgrade-guide.md Outdated Show resolved Hide resolved
docs/guides/1.2.0-upgrade-guide.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@RichardSmedley RichardSmedley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a few style and other comments, but will leave the rest with the SME (Talina).

@aniket-Kumar-c aniket-Kumar-c merged commit b7f6644 into main Apr 25, 2024
4 checks passed
@aniket-Kumar-c aniket-Kumar-c added the no-changelog-needed This is a change not to be tracked in the changelog label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-needed This is a change not to be tracked in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants