DOC-12385: Copy across missing snippets #891
Conversation
Move snippets from p2psync-websocket.cs to Program.cs
ElliotFrancisHunter
requested review from
osfameron,
RichardSmedley,
simon-dew and
bfavini
|
This has broken compilation and cannot be merged |
|
Thanks @borrrden - who of the devs can we ask to look at that? |
|
Ideally it would be the person who wrote them that puts them in correctly. Otherwise it's going to be me. Are all of these snippets needed? Some of them are just one line which seems a bit excessive to create an entire self contained snippet for. |
There was a problem hiding this comment.
Would like some clarification here on whether these are all important. There are a lot of tags in here including "how to call start" which seems pretty obvious, does it really need a snippet?
Anyway perhaps a description of what each one wants to do is in order because some of them are suspicious. I'll put in comments inline.
| // . . . preceding code. for example . . . | ||
| private static ListenerToken _thisListenerToken; | ||
| var Database thisDB; | ||
| // . . . other code . . . |
There was a problem hiding this comment.
What is this meant to represent?
| // tag::p2p-act-rep-config-cont[] | ||
| // Configure Sync Mode | ||
| thisConfig.Continuous = true; // default value |
There was a problem hiding this comment.
This is not the default for this property
| // tag::p2p-act-rep-start[] | ||
| // Start replicator | ||
| thisReplicator.Start(); // <.> |
There was a problem hiding this comment.
This is the same as starting any other replicator...does it really need a separate snippet?
| // end::p2p-act-rep-config-cacert[] | ||
|
|
||
| #warning p2p-act-rep-config-cacert-pinned used, but contains nothing | ||
| // tag::p2p-act-rep-config-cacert-pinned[] | ||
| // Only CA Certs accepted |
There was a problem hiding this comment.
Misleading comment here. Only certificates issued by this CA are accepted, not any CA cert.
| while (_thisReplicator.Status.Activity != ReplicatorActivityLevel.Stopped) { | ||
| // Database cannot close until replicators are stopped | ||
| Console.WriteLine($"Waiting for replicator to stop (currently {_thisReplicator.Status.Activity})..."); | ||
| Thread.Sleep(200); |
There was a problem hiding this comment.
This is quite domain specific and unlikely to make a helpful snippet
| Console.WriteLine($"Waiting for replicator to stop (currently {_thisReplicator.Status.Activity})..."); | ||
| Thread.Sleep(200); | ||
| } | ||
| _thisDatabase.Close(); |
| // tag::p2p-act-rep-stop[] | ||
| // Stop replication. | ||
| thisReplicator.Stop(); // <.> |
There was a problem hiding this comment.
Same as any other replication...
Move snippets from p2psync-websocket.cs to Program.cs