Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CXXCBC-602: Columnar - report first non-retriable code/message in query error #667

Conversation

DemetrisChr
Copy link
Contributor

Motivation

Columnar Error/Retry RFC revision 9:

If the list of errors in a query response contains at least one non-retriable error, the first non-retriable error in the array is selected. Otherwise, the first retriable error in the array is selected.

Changes

  • Report the first non-retriable error in the columnar query error properties, if it exists. Otherwise, report the first error.

Results

FIT tests pass (Tested via the Python SDK)

@DemetrisChr DemetrisChr force-pushed the CXXCBC-602-non-retriable-columnar-error branch from 8c2b501 to b6b50a6 Compare October 3, 2024 10:40
@DemetrisChr DemetrisChr marked this pull request as ready for review October 3, 2024 10:41
Copy link
Contributor

@thejcfactor thejcfactor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@DemetrisChr DemetrisChr merged commit a96ff03 into couchbase:main Oct 3, 2024
19 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants