Use timestamp from the tag for reproducible tarballs #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To improve stability of the tarballs, we need to make sure that that the package does not have changing parts for releases. But at the same time, it is useful to have build date recorded. This patch instructs cmake to use timestamp from the tag, if it exists (GA packages), so the checksum of the tarballs would never change even if the tarball will be produced later on different machine. Embedded certificates would still affect reproducibility, but it is unlikely that they would change frequently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve stability of the tarballs, we need to make sure that that the package does not have changing parts for releases. But at the same time, it is useful to have build date recorded. This patch instructs cmake to use timestamp from the tag, if it exists (GA packages), so the checksum of the tarballs would never change even if the tarball will be produced later on different machine. Embedded certificates would still affect reproducibility, but it is unlikely that they would change frequently.