CXXCBC-303: build jsonsl with the library #659
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avsej
force-pushed
the
CXXCBC-303-update-jsonsl-build-process
branch
from
670bf20
to
3a3889a
Compare
At this stage, we rather own jsonsl implementation, and it would be easier to compile and maintain it as a part of the main source set.
avsej
force-pushed
the
CXXCBC-303-update-jsonsl-build-process
branch
from
3a3889a
to
9ea3bef
Compare
|
I think I'd rather defer this change for later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this stage, we rather own jsonsl implementation, and it would be easier to compile and maintain it as a part of the main source set.
The changes in the library is just result of tidy and formatter scripts, nothing really changed in the library except the build process