Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove non-existing ibc-client-cw link in workspace #1358

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

Farhad-Shabani
Copy link
Member

Closes: #1357


PR author checklist:

  • Added changelog entry, using unclog.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.85%. Comparing base (ac53b28) to head (aaf2bd3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1358   +/-   ##
=======================================
  Coverage   66.85%   66.85%           
=======================================
  Files         225      225           
  Lines       22628    22628           
=======================================
  Hits        15127    15127           
  Misses       7501     7501           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@rnbguy rnbguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Farhad-Shabani Farhad-Shabani added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit e50ae6c Oct 16, 2024
14 checks passed
@Farhad-Shabani Farhad-Shabani deleted the farhad/remove-ibc-client-cw-from-workspace branch October 16, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Cargo.toml has a link to non-existing ibc-client-cw
2 participants