Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ibc-testkit integration tests into tests-integration directory #1233

Merged
merged 30 commits into from
May 23, 2024

Conversation

seanchen1991
Copy link
Contributor

Closes: #1232

Description


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@seanchen1991 seanchen1991 requested a review from rnbguy May 21, 2024 20:31
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 10.00000% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 65.56%. Comparing base (2679767) to head (a2174a8).

Files Patch % Lines
ibc-testkit/src/utils/mod.rs 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1233      +/-   ##
==========================================
- Coverage   67.33%   65.56%   -1.77%     
==========================================
  Files         234      234              
  Lines       23547    23519      -28     
==========================================
- Hits        15855    15421     -434     
- Misses       7692     8098     +406     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tests-integration/README.md Outdated Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
Signed-off-by: Rano | Ranadeep <[email protected]>
Copy link
Collaborator

@rnbguy rnbguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work ! 🙌

@seanchen1991 seanchen1991 added this pull request to the merge queue May 23, 2024
Merged via the queue into main with commit 2378cd4 May 23, 2024
20 checks passed
@seanchen1991 seanchen1991 deleted the sean/move-integration-tests branch May 23, 2024 13:23
Farhad-Shabani pushed a commit that referenced this pull request Sep 9, 2024
…ry (#1233)

* Move ibc-testkit tests into tests-integration directory

* Fix include_str paths

* Remove unnecessary dependencies from ibc-testkit

* Remove unnecessary dev-dependencies from ibc-testkit

* Add ibc-testkit/serde to serde dependency

* Format ibc-testkit cargo.toml

* Remove unnecessary serde feature from tests-integration crate

* Fix typos

* Move json test data into ibc-testkit

* Move some tests around

* Cargo fmt check

* Gate tests behind serde feature

* Switch doc_comment to doc attribute

* Remove doc-comment dependency

* Move client state unit tests back to ibc-clients

* Add comment about internal crates

* Move test_serialization_roundtrip function to utils

* Assert that serialized string matches json input

* Change serde_json -> dep:serde_json

* Remove features section from cargo.toml

* Remove unused imports

* taplo fmt

* Add features section back to cargo.toml

* update readme and crate description

* format toml

* disable features

Signed-off-by: Rano | Ranadeep <[email protected]>

---------

Signed-off-by: Rano | Ranadeep <[email protected]>
Co-authored-by: Ranadeep Biswas <[email protected]>
Co-authored-by: Rano | Ranadeep <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move ibc-testkit tests to a separate non-publishing crate
2 participants