-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ibc-testkit
integration tests into tests-integration
directory
#1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1233 +/- ##
==========================================
- Coverage 67.33% 65.56% -1.77%
==========================================
Files 234 234
Lines 23547 23519 -28
==========================================
- Hits 15855 15421 -434
- Misses 7692 8098 +406 ☔ View full report in Codecov by Sentry. |
…os/ibc-rs into sean/move-integration-tests
rnbguy
reviewed
May 22, 2024
rnbguy
reviewed
May 22, 2024
rnbguy
reviewed
May 22, 2024
rnbguy
reviewed
May 22, 2024
rnbguy
reviewed
May 22, 2024
rnbguy
reviewed
May 22, 2024
rnbguy
reviewed
May 22, 2024
rnbguy
reviewed
May 22, 2024
rnbguy
reviewed
May 22, 2024
rnbguy
reviewed
May 22, 2024
rnbguy
reviewed
May 22, 2024
rnbguy
reviewed
May 22, 2024
rnbguy
reviewed
May 22, 2024
…e-integration-tests
rnbguy
reviewed
May 23, 2024
Signed-off-by: Rano | Ranadeep <[email protected]>
rnbguy
approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work ! 🙌
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
…ry (#1233) * Move ibc-testkit tests into tests-integration directory * Fix include_str paths * Remove unnecessary dependencies from ibc-testkit * Remove unnecessary dev-dependencies from ibc-testkit * Add ibc-testkit/serde to serde dependency * Format ibc-testkit cargo.toml * Remove unnecessary serde feature from tests-integration crate * Fix typos * Move json test data into ibc-testkit * Move some tests around * Cargo fmt check * Gate tests behind serde feature * Switch doc_comment to doc attribute * Remove doc-comment dependency * Move client state unit tests back to ibc-clients * Add comment about internal crates * Move test_serialization_roundtrip function to utils * Assert that serialized string matches json input * Change serde_json -> dep:serde_json * Remove features section from cargo.toml * Remove unused imports * taplo fmt * Add features section back to cargo.toml * update readme and crate description * format toml * disable features Signed-off-by: Rano | Ranadeep <[email protected]> --------- Signed-off-by: Rano | Ranadeep <[email protected]> Co-authored-by: Ranadeep Biswas <[email protected]> Co-authored-by: Rano | Ranadeep <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1232
Description
PR author checklist:
unclog
.docs/
).Reviewer checklist:
Files changed
in the GitHub PR explorer.