Add height request field to all gRPC queries #248
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-axner
commented
Jul 12, 2021
| @@ -34,7 +34,8 @@ const _ = proto.GoGoProtoPackageIsVersion3 // please upgrade the proto package | |||
| // method | |||
| type QueryDenomTraceRequest struct { | |||
| // hash (in hex format) of the denomination trace information. | |||
| Hash string `protobuf:"bytes,1,opt,name=hash,proto3" json:"hash,omitempty"` | |||
| Hash string `protobuf:"bytes,1,opt,name=hash,proto3" json:"hash,omitempty"` | |||
| Height uint64 `protobuf:"varint,2,opt,name=height,proto3" json:"height,omitempty"` | |||
There was a problem hiding this comment.
Would QueryHeight be a better name? Should we use uint64 or int64?
There was a problem hiding this comment.
Will update to QueryHeight and keep uint64. QueryHeight won't cause name collisions as Height might
|
Closing, this has become lower priority for me |
faddat
referenced
this pull request
in notional-labs/ibc-go
Feb 23, 2022
Update required go version to v1.14 in go.mod
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #149
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes