Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(runtime/v2): use AppI.GetStore() to fetch an initialized RootStore (backport #22205) #22224

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 10, 2024

Description

Alternative to: #22204


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:

  • confirmed ! in the type prefix if API or client breaking change

  • targeted the correct branch (see PR Targeting)

  • provided a link to the relevant issue or specification

  • reviewed "Files changed" and left comments if necessary

  • included the necessary unit and integration tests

  • added a changelog entry to CHANGELOG.md

  • updated the relevant documentation or specification, including comments for documenting Go code

  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • Refactor

    • Simplified store management by removing the singleton store builder pattern.
    • Streamlined command initialization processes for improved readability and efficiency.
    • Enhanced the application interface for easier store access.
  • General Cleanup

    • Removed unused variables and import statements for a cleaner codebase.
    • Improved error messaging for better clarity during configuration unmarshalling.

This is an automatic backport of pull request #22205 done by [Mergify](https://mergify.com).

…tStore (#22205)

(cherry picked from commit dd2369d)

# Conflicts:
#	runtime/v2/module.go
#	runtime/v2/store.go
#	server/v2/server_test.go
#	server/v2/store/server.go
#	server/v2/types.go
@mergify mergify bot requested a review from a team as a code owner October 10, 2024 14:35
@mergify mergify bot added the conflicts label Oct 10, 2024
Copy link
Contributor Author

mergify bot commented Oct 10, 2024

Cherry-pick of dd2369d has failed:

On branch mergify/bp/release/v0.52.x/pr-22205
Your branch is up to date with 'origin/release/v0.52.x'.

You are currently cherry-picking commit dd2369daf.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   server/v2/cometbft/server.go
	modified:   simapp/v2/app_di.go
	modified:   simapp/v2/app_test.go
	modified:   simapp/v2/simdv2/cmd/commands.go
	modified:   simapp/v2/simdv2/cmd/root_di.go
	modified:   simapp/v2/simdv2/cmd/testnet.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   runtime/v2/module.go
	deleted by us:   runtime/v2/store.go
	deleted by us:   server/v2/server_test.go
	deleted by us:   server/v2/store/server.go
	deleted by us:   server/v2/types.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@github-actions github-actions bot added C:server/v2 Issues related to server/v2 C:server/v2 cometbft labels Oct 10, 2024
@julienrbrt julienrbrt merged commit 3f4a25d into release/v0.52.x Oct 10, 2024
71 of 73 checks passed
@julienrbrt julienrbrt deleted the mergify/bp/release/v0.52.x/pr-22205 branch October 10, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:server/v2 cometbft C:server/v2 Issues related to server/v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants