Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds settings.trace_mode and skip cholesky jitter #27

Merged
merged 4 commits into from
Nov 8, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions linear_operator/settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -551,6 +551,24 @@ class terminate_cg_by_size(_feature_flag):
_default = False


class trace_mode(_feature_flag):
"""
If set to True, we will generally try to avoid calling our built in PyTorch functions, because these cannot
be run through torch.jit.trace.

Note that this will sometimes involve explicitly evaluating lazy tensors and various other slowdowns and
inefficiencies. As a result, you really shouldn't use this feature context unless you are calling torch.jit.trace
on a GPyTorch model.

Our hope is that this flag will not be necessary long term, once https://github.com/pytorch/pytorch/issues/22329
is fixed.

(Default: False)
"""

_default = False


class tridiagonal_jitter(_value_context):
"""
The (relative) amount of noise to add to the diagonal of tridiagonal matrices before
Expand Down
2 changes: 1 addition & 1 deletion linear_operator/utils/cholesky.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def _psd_safe_cholesky(A, out=None, jitter=None, max_tries=None):
out = (out, torch.empty(A.shape[:-2], dtype=torch.int32, device=out.device))

L, info = torch.linalg.cholesky_ex(A, out=out)
if not torch.any(info):
if settings.trace_mode.on() or not torch.any(info):
return L

isnan = torch.isnan(A)
Expand Down