Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: conditionally enable plugins for multi-app environments #130

Merged
merged 5 commits into from
Jun 9, 2024

Conversation

EsadCetiner
Copy link
Member

Documents how to conditionally enable plugins when using them in a multi-app environment, some users have issues with this as seen in coreruleset/coreruleset#3655

When this is merged, I'll update all plugins readme to link to this.

Copy link
Contributor

@theseion theseion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! I think it would be good to make it explicit, which version of ModSecurity this is for. Does the same work for v3 / nginx?

content/concepts/plugins.md Outdated Show resolved Hide resolved
content/concepts/plugins.md Outdated Show resolved Hide resolved
content/concepts/plugins.md Outdated Show resolved Hide resolved
content/concepts/plugins.md Outdated Show resolved Hide resolved
@EsadCetiner
Copy link
Member Author

@theseion both ModSecurity2 and libModSecurity3 support SecWebAppID so the process is the same.

content/concepts/plugins.md Outdated Show resolved Hide resolved
content/concepts/plugins.md Outdated Show resolved Hide resolved
content/concepts/plugins.md Outdated Show resolved Hide resolved
content/concepts/plugins.md Outdated Show resolved Hide resolved
@EsadCetiner EsadCetiner merged commit e756353 into coreruleset:main Jun 9, 2024
1 check passed
@EsadCetiner EsadCetiner deleted the docs-multi-app-plugins branch June 9, 2024 13:07
@EsadCetiner
Copy link
Member Author

@theseion I don't see my changes in https://coreruleset.org/docs/concepts/plugins/ is there something I need to do to publish this?

@theseion
Copy link
Contributor

Just added the last entry to the list here: coreruleset/website#64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants