feat: fail format validation on unnecessary uppercase character classes #166
+144
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theseion
force-pushed
the
lint-uppercase-character-classes-in-case-insensitive-expressions
branch
2 times, most recently
from
da60552
to
8c1e2ac
Compare
fzipi
reviewed
Jul 15, 2024
Check only character classes for uppercase letters in case-insensitive expressions. Other casing in assembly files can give context and it may be better to leave it as is.
theseion
force-pushed
the
lint-uppercase-character-classes-in-case-insensitive-expressions
branch
from
37e3e5c
to
c7cd767
Compare
theseion
force-pushed
the
lint-uppercase-character-classes-in-case-insensitive-expressions
branch
from
c7cd767
to
d388fa1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check only character classes for uppercase letters in case-insensitive expressions. Other casing in assembly files can give context and it may be better to leave it as is.