identity: introspect basearch #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlebon
reviewed
Jul 4, 2019
This introspects node basearch from rpm-ostree, instead of using build-time configuration and the internal mapping table.
|
Ouch, I totally missed one level of nesting. To compensate for that, I've know added fixtures and mock to cover the deserialization part, PTAL. |
lucab
commented
Jul 4, 2019
jlebon
approved these changes
Jul 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introspects node basearch from rpm-ostree, instead of using
build-time configuration and the internal mapping table.
Ref: coreos/coreos-assembler#590
Closes: #54