Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treefile: Add an edition && treefile: Add finalize.d #5117

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

cgwalters
Copy link
Member

@cgwalters cgwalters commented Oct 3, 2024

Revert "build(deps): bump regex from 1.10.6 to 1.11.0"

This reverts commit c46951f.

Signed-off-by: Colin Walters [email protected]


treefile: Add an edition

This will allow us to clean up some defaults and change some semantics.
In particular, I'd like to add an opinionated mechanism to copy files
from git into the build.

For now, edition: "2024" just flips on tmp-is-dir: true and fixes
boot-location.

Signed-off-by: Colin Walters [email protected]


treefile: Add finalize.d

This is a total escape hatch for arbitrary mutation of
the filesystem tree just before we do an ostree commit.

Signed-off-by: Colin Walters [email protected]


@cgwalters cgwalters changed the title treefile: Add an edition treefile: Add an edition && treefile: Add finalize.d Oct 4, 2024
Copy link
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not tested. Should we move this to the experimental section for now while we test it as we might want to iterate on the behavior?

@cgwalters
Copy link
Member Author

Should we move this to the experimental section for now while we test it as we might want to iterate on the behavior?

Yeah agreed, good point. Done!

This will allow us to clean up some defaults and change some semantics.
In particular, I'd like to add an opinionated mechanism to copy files
from git into the build.

For now, `edition: "2024"` just flips on `tmp-is-dir: true` and fixes
`boot-location`.

Signed-off-by: Colin Walters <[email protected]>
This is a total escape hatch for arbitrary mutation of
the filesystem tree just before we do an ostree commit.

Signed-off-by: Colin Walters <[email protected]>
@cgwalters cgwalters merged commit 664c6ee into coreos:main Oct 4, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants