Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daemon: Record the agent ID in the journal #2395

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

cgwalters
Copy link
Member

Related to #1747

Basically after this we can have rpm-ostree status output
e.g. Agent: zincati at least after an upgrade has happened.

Related to coreos#1747

Basically after this we can have `rpm-ostree status` output
e.g. `Agent: zincati` at least *after* an upgrade has happened.
@cgwalters
Copy link
Member Author

A lot of the internal data passing here is only necessary because internally we've tried to keep somewhat of a wall between "daemon code" and "do ostree stuff", but in practice I think we should move towards having those together. Or perhaps inner code calls rpmostreed_daemon_get() (global state) and at least doesn't crash if it's not available.

Copy link
Contributor

@lucab lucab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, lucab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9d927e9 into coreos:master Dec 16, 2020
kelvinfan001 added a commit to kelvinfan001/rpm-ostree that referenced this pull request Jan 15, 2021
In coreos#2395, agent's id is
recorded in the journal. Similarly, record the systemd service that
called the client, as well.

Related to coreos#1747.
kelvinfan001 added a commit to kelvinfan001/rpm-ostree that referenced this pull request Jan 15, 2021
In coreos#2395, agent's id is
recorded in the journal. Similarly, record the systemd service that
called the client, as well.

Related to coreos#1747.
kelvinfan001 added a commit to kelvinfan001/rpm-ostree that referenced this pull request Jan 19, 2021
In coreos#2395, agent's id is
recorded in the journal. Similarly, record the systemd service that
called the client, as well.

Related to coreos#1747.
kelvinfan001 added a commit to kelvinfan001/rpm-ostree that referenced this pull request Jan 19, 2021
In coreos#2395, agent's id is
recorded in the journal. Similarly, record the systemd service that
called the client, as well.

Related to coreos#1747.
openshift-merge-robot pushed a commit that referenced this pull request Jan 20, 2021
In #2395, agent's id is
recorded in the journal. Similarly, record the systemd service that
called the client, as well.

Related to #1747.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants