-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
daemon: Record the agent ID in the journal #2395
Conversation
Related to coreos#1747 Basically after this we can have `rpm-ostree status` output e.g. `Agent: zincati` at least *after* an upgrade has happened.
A lot of the internal data passing here is only necessary because internally we've tried to keep somewhat of a wall between "daemon code" and "do ostree stuff", but in practice I think we should move towards having those together. Or perhaps inner code calls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, lucab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In coreos#2395, agent's id is recorded in the journal. Similarly, record the systemd service that called the client, as well. Related to coreos#1747.
In coreos#2395, agent's id is recorded in the journal. Similarly, record the systemd service that called the client, as well. Related to coreos#1747.
In coreos#2395, agent's id is recorded in the journal. Similarly, record the systemd service that called the client, as well. Related to coreos#1747.
In coreos#2395, agent's id is recorded in the journal. Similarly, record the systemd service that called the client, as well. Related to coreos#1747.
Related to #1747
Basically after this we can have
rpm-ostree status
outpute.g.
Agent: zincati
at least after an upgrade has happened.