Skip to content
This repository has been archived by the owner on May 7, 2021. It is now read-only.

vendor: netlink bump to 9cff81214893f3b52dfc307a45669eb7f96fcada for s390x support #1049

Merged
merged 1 commit into from
Aug 27, 2019

Conversation

barthy1
Copy link
Contributor

@barthy1 barthy1 commented Aug 26, 2019

Bump netlink to 9cff81214893f3b52dfc307a45669eb7f96fcada commit to pick up the big endian fix for s390x, required to run kola.
The details described at #1044

Bump netlink to 9cff81214893f3b52dfc307a45669eb7f96fcada commit to pick up the big endian fix for s390x, required to run kola
@barthy1
Copy link
Contributor Author

barthy1 commented Aug 26, 2019

@alicefr

Copy link
Contributor

@arithx arithx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff looks pretty minimal. I did a full run of CL on both QEMU & Unprivileged QEMU as well as FCOS on QEMU and both seemed to work.

@miabbott do you mind doing a quick set of runs against the latest RHCOS images of each branch to make sure nothing is impacted?

LGTM

@miabbott
Copy link
Member

@miabbott do you mind doing a quick set of runs against the latest RHCOS images of each branch to make sure nothing is impacted?

Sure; I'm digging out of PTO email backlog today, but will complete this by tomorrow (Tues Aug 27)

@miabbott
Copy link
Member

@miabbott do you mind doing a quick set of runs against the latest RHCOS images of each branch to make sure nothing is impacted?

I found that RHCOS 4.1 was failing on coreos.ignition.resource.s3 both with and without this PR.

Additionally, RHCOS 4.2 required that the podman.* tests were blacklisted to complete successfully, both with and without this PR.

The podman issue is known (sorting things out in RHBZ#1729603); the failed Ignition test is a new one that will have to be investigated.

In summary, this PR doesn't appear to impact tests on RHCOS, so it should be safe to merge. 👍

@arithx arithx merged commit bc77377 into coreos:master Aug 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants